From 11f39e845649d79d570d261f0ded3ed1da5a959e Mon Sep 17 00:00:00 2001
From: chausman <chausman@nrao.edu>
Date: Thu, 18 May 2023 11:43:53 -0600
Subject: [PATCH] add DOOM comment
---
.../pexable/carta_envoy/carta_envoy/launchers.py | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/apps/cli/executables/pexable/carta_envoy/carta_envoy/launchers.py b/apps/cli/executables/pexable/carta_envoy/carta_envoy/launchers.py
index f66681748..abfba6476 100644
--- a/apps/cli/executables/pexable/carta_envoy/carta_envoy/launchers.py
+++ b/apps/cli/executables/pexable/carta_envoy/carta_envoy/launchers.py
@@ -188,7 +188,11 @@ class CartaLauncher:
try:
# finish setup for CARTA and ensure completion before launch
CartaWrapperLauncher.deploy_wrapper_html(file_browser_path, carta_url, session_timeout_date)
- time.sleep(3)
+ # BIG NASTY COMMENT OF DOOM!!!!!
+ # DO NOT REMOVE!!
+ # This is required to ensure that proxy url setup is complete *before* CARTA launches.
+ # Without this, users are presented with a 404 page on launch as of CARTA3
+ time.sleep(2)
# start CARTA
CARTA_PROCESS = subprocess.Popen(
@@ -202,8 +206,6 @@ class CartaLauncher:
self.teardown()
sys.exit(f"ERROR: Failed to launch CARTA: {err}")
else:
- # CartaWrapperLauncher.deploy_wrapper_html(file_browser_path, carta_url, session_timeout_date)
-
# CARTA is running and accessible, so send CARTA URL to AAT system or notify user
self.notify_ready(wrapper_url)
--
GitLab