From dd8ed472b8f74f7149ba747b8a35abc81de3cd84 Mon Sep 17 00:00:00 2001
From: chausman <chausman@nrao.edu>
Date: Tue, 18 Apr 2023 15:56:26 -0600
Subject: [PATCH] make carta send correct failure when failing.

---
 .../workspaces/workflow/services/workflow_service.py         | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/shared/workspaces/workspaces/workflow/services/workflow_service.py b/shared/workspaces/workspaces/workflow/services/workflow_service.py
index 894eb03c7..78d2e872b 100644
--- a/shared/workspaces/workspaces/workflow/services/workflow_service.py
+++ b/shared/workspaces/workspaces/workflow/services/workflow_service.py
@@ -1107,6 +1107,11 @@ class WorkflowMessageHandler:
 
             if wf_request.workflow_name == "carta":
                 wf_key = "carta-instance-ready"
+                if event_type == "complete":
+                    # carta exist by killing its processes which condor reads as an error.
+                    # A 'normal' exit 0 for carta is actually a failure and the carta_complete message doesn't exist.
+                    # fix message type
+                    event_type = "failed"
             else:
                 wf_key = wf_request.workflow_name
 
-- 
GitLab