Skip to content

Proposal submit endpoint

Mark Ferguson requested to merge STT-1029-create-submit-endpoint into 0.2-DEVELOPMENT

I would appreciate a review of this to answer the following questions:

  • that the PUT URL pattern for the endpoint is acceptable (it is currently /proposals/{proposal_id}/{state} where state can be "Draft", "Submitted", etc.

  • Currently, I am assuming that the state desired in the above pattern matches the statuses provided in propose/domain_layer/entities/src/proposal.py. This defines that the expected first letter is capitalized, which is not something you typically see in URLs (at least in our application)

--- A) should we always pass lowercase versions and capitalize in the endpoint (seems janky)? --- B) should we change our definition of statues to be lowercase? --- C) is there another method that would be more robust?

Thanks for taking the time to review and provide your thoughts on the above.

Merge request reports