Skip to content

Added back old update-CD endpoint, changing some stuff

Sam Kagan requested to merge make-cd-updates-atomic into main

Stuff changed:

  • Now ensures that the ConflictDeclarations in the request are exactly one ScienceReviewer's complete set
  • Altered CD state-transition validator service to allow "transitions" where the CD's state doesn't change
    • Also allowed TTA Members to transition from anything to Unknown, this seemed like an unnecessary restriction
  • Removed Unknown->AutomaticallyConflicted from set of state transitions considered valid by validator
    • This state transition should never be used by any user (even TTA Members), only the backend should be allowed to transition CDs to AutomaticallyConflicted
    • As a result, removed validator call from set-auto-conflicts service, which also allows that service to change any CD to AutomaticallyConflicted regardless of its starting state
      • TTA members can still change the states of AutomaticallyConflicted CDs
      • I don't think we need to fail auto-conflict declaration because some CD that should be automatically marked as Conflicted was in some state other than Unknown

Merge request reports