lose_meaningless_tests

apps/cli/executables/pexable/ingest/tests/unit/test_eb_persistence.py → apps/cli/executables/pexable/ingest/test/test_eb_persistence.py

@@ -15,11 +15,19 @@
 #
 # You should have received a copy of the GNU General Public License
 # along with Workspaces.  If not, see <https://www.gnu.org/licenses/>.
+
+# pylint: disable=C0114, C0103, E0401, E0402
+
 import pyat
 from pyat.schema import ExecutionBlock, Filegroup, Project, RealfastExecutionBlock
 
 
 def test_realfast_execblock_persistence():
+    """
+    Test for persistents of realfast execution blocks.
+
+    :return:
+    """
     p = Project()
     p.project_code = "foo"
     fg = Filegroup()

apps/cli/executables/pexable/ingest/tests/unit/test_ingestion_manifest.py → apps/cli/executables/pexable/ingest/test/test_ingestion_manifest.py

@@ -15,6 +15,11 @@
 #
 # You should have received a copy of the GNU General Public License
 # along with Workspaces.  If not, see <https://www.gnu.org/licenses/>.
+
+""" Tests of the ingestion manifest """
+
+# pylint: disable=C0116, E0401, W0621
+
 from pathlib import Path
 
 import pyat.ingestion.manifestpersist as mp
@@ -35,7 +40,7 @@ def ingestion_manifest():
 def realfast_metadata():
     manifest = IngestionManifest(INGESTION_MANIFEST_FILE)
     if manifest.has_collection():
-        collection_metadata_file = Path(".") / manifest.get_additional_metadata_file()
+        collection_metadata_file = Path("unit") / manifest.get_additional_metadata_file()
         json_metadata = JSONMetadata(collection_metadata_file)
         if json_metadata.isRealFast():
             realfast_metadata = RealFastMetadata(json_metadata)
@@ -51,9 +56,9 @@ def test_associate_group(ingestion_manifest):
     assert ingestion_manifest.get_associate_group_locator() == "uid://evla/execblock/abcd-efgh-ijkl-mnop"
 
 
-@pytest.mark.skip(reason="Ignoring for now")
+# @pytest.mark.skip(reason="Ignoring for now")
 def test_type(realfast_metadata):
-    assert type(realfast_metadata) == RealFastMetadata
+    assert isinstance(realfast_metadata, RealFastMetadata)
 
 
 # TODO
@@ -80,7 +85,7 @@ def test_realfast_attributes(realfast_metadata):
 @pytest.mark.skip(reason="Ignoring for now")
 def test_realfast_execution_block(realfast_metadata):
     execution_block = RealfastExecutionBlock()
-    assert type(execution_block) == RealfastExecutionBlock
+    assert isinstance(execution_block, RealfastExecutionBlock)
     execution_block.transient_ra = realfast_metadata.get_transient_ra()
     assert execution_block.transient_ra == realfast_metadata.get_transient_ra()
 

apps/cli/executables/pexable/ingest/tests/functional/test_func_one.py

-#
-# Copyright (C) 2021 Associated Universities, Inc. Washington DC, USA.
-#
-# This file is part of NRAO Workspaces.
-#
-# Workspaces is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Workspaces is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Workspaces.  If not, see <https://www.gnu.org/licenses/>.
-import pytest
-
-
-@pytest.mark.skip(reason="Example skipped test")
-def test_one():
-    assert 1 == 0
-
-
-def test_two():
-    assert 1 == 1

apps/cli/executables/pexable/ingest/tests/unit/__init__.py

-#
-# Copyright (C) 2021 Associated Universities, Inc. Washington DC, USA.
-#
-# This file is part of NRAO Workspaces.
-#
-# Workspaces is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Workspaces is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Workspaces.  If not, see <https://www.gnu.org/licenses/>.

apps/cli/executables/pexable/ingest/tests/unit/test_unit_one.py

-#
-# Copyright (C) 2021 Associated Universities, Inc. Washington DC, USA.
-#
-# This file is part of NRAO Workspaces.
-#
-# Workspaces is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Workspaces is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Workspaces.  If not, see <https://www.gnu.org/licenses/>.
-import pytest
-
-
-@pytest.mark.skip(reason="Example skipped test")
-def test_one():
-    assert 1 == 0
-
-
-def test_two():
-    assert 1 == 1