do it better

apps/cli/executables/pexable/ingest_envoy/ingest_envoy/ingestion_manifest.py

@@ -98,14 +98,15 @@ class IngestionManifest(ManifestComponentIF):
         """Determine and retrieve the correct ingestNGAS flag for this type of ingestion/curation"""
 
         # default to true for all types
-        flag = True
-        if self.sp_type == ScienceProductType.EXEC_BLOCK:
-            # EB ingestion might create duplicate file versions during testing, check flag state
-            flag = CapoConfig().getboolean("archive-ingestion.ingestNGAS.observation")
-        elif self.sp_type == ScienceProductType.EVLA_CAL:
-            flag = CapoConfig().getboolean("archive-ingestion.ingestNGAS.calibration")
-        elif self.sp_type == ScienceProductType.IMAGE or self.sp_type == ScienceProductType.VLASS_SECI:
-            flag = CapoConfig().getboolean("archive-ingestion.ingestNGAS.imaging")
+        match self.sp_type:
+            case ScienceProductType.EXEC_BLOCK:
+                flag = CapoConfig().getboolean("archive-ingestion.ingestNGAS.observation")
+            case ScienceProductType.EVLA_CAL:
+                flag = CapoConfig().getboolean("archive-ingestion.ingestNGAS.calibration")
+            case ScienceProductType.IMAGE | ScienceProductType.VLASS_SECI:
+                flag = CapoConfig().getboolean("archive-ingestion.ingestNGAS.imaging")
+            case _:
+                flag = True
 
         return flag