Skip to content
Snippets Groups Projects

WS-2215 Editor modal scrubbing

Merged Daniel Nemergut requested to merge ws2215-editor_modal_scrubbing into 2.8.2.3-DEVELOPMENT
1 unresolved thread

The editor modal was allowing empty content to persist to the database. This was because the modal actually saves the new content and if this was an empty object (by leaving the modal open or mischievous behavior) then it would wipe the contents of existing database entry.

The last time we saw this we prevented one of the endpoints from persisting empty data. This MR does that for the capability_version_files table and puts a stop-gap on the UI by not allowing an empty object from being sent to the endpoint.

The behavior is a little odd if someone actually WANTS to clear file content by submitting an empty form, but I don't anticipate that happening (some user will prove me wrong).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
96 96 "with": "src/environments/environment.dev.ts"
97 97 }
98 98 ],
99 "optimization": true,
99 "optimization": false,
  • Charlotte Hausman
  • Charlotte Hausman approved this merge request

    approved this merge request

  • Daniel Nemergut added 1 commit

    added 1 commit

    • e867da4a - Added a note for our future selves

    Compare with previous version

  • Daniel Nemergut added 11 commits

    added 11 commits

    • e867da4a...305a5b40 - 7 commits from branch 2.8.2.3-DEVELOPMENT
    • 1e63d35b - Disabling webpack on dev to simplify JS debugging
    • 88ab7590 - Preventing the save button from persisting an empty form on the editor modal
    • 41c4def6 - Checking that the request body has content before saving a capability version file
    • 4029831c - Added a note for our future selves

    Compare with previous version

  • Daniel Nemergut added 1 commit

    added 1 commit

    • 24c83f3c - Revert "Disabling webpack on dev to simplify JS debugging"

    Compare with previous version

  • Sam Kagan approved this merge request

    approved this merge request

  • Daniel Nemergut mentioned in commit aa0c5374

    mentioned in commit aa0c5374

  • Please register or sign in to reply
    Loading