Skip to content
Snippets Groups Projects

Removing rawdata race conditions

Merged Daniel Nemergut requested to merge ws2227-recycle_raw_data_improvements into main
1 unresolved thread

This prevents a couple of race conditions when reusing the rawdata directory from a previous execution's spool.

First, the workflows now make hard links to the rawdata instead of moving it out of the previous execution's spool. This way, if the previous execution is still running, there will still be a rawdata directory for it to work with.

Second, the prev_processing_dir parameter only gets passed to the workflow when the previous execution has finished running the productfetcher. This prevents copying over a partially fetched rawdata directory.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
785 785 current_version_files = request.current_version.files
786 786
787 787 # Store the previous execution's spool directory for reusing bits of it
788 if request.current_version.workflow_metadata:
788 # Note: This is currently limited to capabilities that update the fetch stage
789 if (request.current_version.workflow_metadata
790 and request.current_version.workflow_metadata["processing_dir"]
  • Daniel Nemergut resolved all threads

    resolved all threads

  • Hard links seem like a very elegant solution here!

  • Daniel Nemergut added 1 commit

    added 1 commit

    • 1728a40d - Checking metadata keys not values

    Compare with previous version

  • Charlotte Hausman approved this merge request

    approved this merge request

  • Sam Kagan approved this merge request

    approved this merge request

  • Daniel Nemergut mentioned in commit 9c743c3c

    mentioned in commit 9c743c3c

  • Please register or sign in to reply
    Loading