Skip to content
Snippets Groups Projects

fix a few issues causing errors

Merged fix a few issues causing errors
oops-fixes into 2.8.4-DEVELOPMENT
1 unresolved thread
Merged Charlotte Hausman requested to merge oops-fixes into 2.8.4-DEVELOPMENT
1 unresolved thread
  • The queue manger requires a max_jobs value to exist
  • make the in-place tweak for reacquire on production permanent

Merge request reports

Merge request pipeline #15564 failed

Stage: pull-db
Stage: test-coverage

Merge request pipeline failed for 065ef9fd

Merged by Charlotte HausmanCharlotte Hausman 10 months ago (May 16, 2024 3:02pm UTC)

Loading

Pipeline #15612 passed

Stage: pull-db
Stage: deploy

Pipeline passed for d36999f1 on 2.8.4-DEVELOPMENT

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
shared/workspaces/workspaces/workflow/services/recovery.py
115 115
116 116 if results_dir.is_dir():
117 117 # because for some reason these are not the same....
118 if results_dir == pathlib.Path(".") or results_dir == pathlib.Path.cwd():
118 if results_dir == pathlib.Path(".") or results_dir == pathlib.Path.cwd() or results_dir == pathlib.Path(""):
  • Sam Kagan
    Sam Kagan @skagan ·
    Owner

    Minor: According to my Python 3.10 REPL, it looks like Path('.') == Path(''). Also, if you used results_dir = Path(...).resolve(), it'd always be absolute, so you wouldn't need to worry about checking against Path('.').

  • Please register or sign in to reply
  • Sam Kagan approved this merge request

    approved this merge request

  • Charlotte Hausman merged

    merged

  • Charlotte Hausman mentioned in commit d36999f1

    mentioned in commit d36999f1

    • Please register or sign in to reply