Skip to content
Snippets Groups Projects

WS-516: UI for showing ingestion complete (archived status)

Merged Nathan Hertz requested to merge WS-516-ingest-complete-ui into main
1 unresolved thread

Request page

  • Added "ARCHIVED" badge that will appear if the ingested boolean flag is set in the database; also updated timestamp formatting
  • Separated input file list markup into new capability-request/files component; added "no files exist" message if active version has no files associated with it
  • Moved request operations (create new version button, submit button) into separate component; did some restyling
  • Updated styling and refactored out the newly organized components

Sandbox

  • Modified sandbox styling to match up more with request page styling

Other

  • Added capability request's ingested boolean to front-end model and back-end JSON serialization

Screenshots

Screen_Shot_2021-07-14_at_10.52.34_AM

Screen_Shot_2021-07-14_at_10.53.11_AM

Merge request reports

Merge request pipeline #2185 passed

Merge request pipeline passed for 4eda1ebf

Test coverage 76.00% (0.00%) from 1 job

Merged by Nathan HertzNathan Hertz 3 years ago (Jul 14, 2021 9:35pm UTC)

Merge details

  • Changes merged into with 6165066b.
  • Deleted the source branch.

Pipeline #2186 passed

Pipeline passed for 6165066b on main

Test coverage 76.00% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Charlotte Hausman approved this merge request

    approved this merge request

  • Janet Goldstein approved this merge request

    approved this merge request

  • UI feedback welcome!

  • Daniel Lyons approved this merge request

    approved this merge request

    • UI looks fine (though I wish we could kidnap @rgivens for our UIs)

    • thanks…? haha

    • it looks fine, unless you want some nick-picky stuff

    • let me guess: it's the centered button. haha

    • One screen has white boxes on a grey background, the other screen has grey boxes on a white background. The width of the body is different between the pages. There appears to be different border-radius - but maybe that's just an illusion, and only one box has a top shadow / border I don't see anywhere else. Also, the centered button - but that may be OK if that button has nothing to do with the two boxes above it - however, if thats the case it should be centered on the whole page width, not just the one column.

      The "null" looks funny as it's not like it's siblings.

      None of these are necessarily "wrong" - just jumps out at me having no context for the rest of the system.

    • Yeah, consistency (body width, etc.) is a really good thing to mention. Our pages basically don't have consistency between each other, and I'm not sure how best to coordinate that.

      Whenever we have a UI sprint, if we could pull you in to get some advice on that, that would be ideal.

    • Please register or sign in to reply
  • merged

Please register or sign in to reply
Loading