Skip to content
Snippets Groups Projects

WS-600: implementing tests for image ingestion manifest output group

Merged Janet Goldstein requested to merge WS-600-image-ingestion-output-group-tests into main
2 unresolved threads

Tests for image ingestion manifest output group are implemented, breaking several existing tests. New and refactored tests that would break the build are skipped temporarily

TODO next MR:

  • fix existing tests that are broken
  • refactor output group construction to accommodate both EVLA CAL and std. imaging manifests

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
232 if AncillaryProductType.INGESTION_ARTIFACTS.value in file.name:
233 return AncillaryProduct(
234 type=AncillaryProductType.INGESTION_ARTIFACTS, filename=str(file)
235 )
299 :return:
300 """
236 301
237 # this is not an ancillary product
238 return None
302 products_finder = ImageIngestionProductsFinder(self.staging_source_dir)
303 science_products = products_finder.science_products
304 ancillary_products = products_finder.ancillary_products
305
306 return OutputGroup(science_products=science_products, ancillary_products=ancillary_products)
307
308 # def _build_ancillary_image_science_product(self, file: Path):
  • 284 weblog = maybe_weblogs[0]
    285 weblog_ap = AncillaryProduct(
    286 type=AncillaryProductType.PIPELINE_WEBLOG_TYPE, filename=weblog.name
    287 )
    288 ancillary_products.append(weblog_ap)
    289
    290 additional_files = self._find_additional_ingestion_files()
    291 for file in additional_files:
    292 maybe_ap = self._build_ancillary_product(file)
    293 if maybe_ap and maybe_ap not in ancillary_products:
    294 ancillary_products.append(maybe_ap)
    295
    296 return ancillary_products
    297
    298 def _find_additional_ingestion_files(self) -> List[Path]:
    388 # def _find_image_products(self) -> List[AncillaryProduct]:
  • Daniel Lyons approved this merge request

    approved this merge request

  • Please register or sign in to reply
    Loading