Skip to content
Snippets Groups Projects

WS-601: Rewrite/refactor ingestion manifest builder to pass disabled tests, part two

Merged WS-601: Rewrite/refactor ingestion manifest builder to pass disabled tests, part two
WS-601-ingestion-manifest-resolve-part-deux into main
1 unresolved thread
Merged Janet Goldstein requested to merge WS-601-ingestion-manifest-resolve-part-deux into main
1 unresolved thread
  • removed redundant test
  • test_miscellaneous_manifests tests pass
  • refactored testing values to central location
  • enum -> str args that I missed

TODO in part 3:

  • re-enable remaining disabled tests and rewrite/refactor to make them pass
  • implement pending tests

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
apps/cli/executables/pexable/ingest_envoy/ingest_envoy/std_img_manifest_utils.py
33 34 if file.name.endswith(".fits") and "rms" not in file.name
34 35 ][0]
35 36 image_files = [
36 file for file in self.files_found if "rms" in file.name or file.name.endswith(".png")
37 file for file in self.files_found if ("rms" in file.name or file.name.endswith(".png"))
  • Daniel Lyons approved this merge request

    approved this merge request

  • Nathan Hertz approved this merge request

    approved this merge request

  • Janet Goldstein added 4 commits

    added 4 commits

    • 668f9658 - 1 commit from branch main
    • 9e154132 - kicking off the pipeline
    • 5652bc9c - WS-601: Rewrite/refactor ingestion manifest builder to pass disabled tests, part two
    • e4cbef68 - Merge branch 'WS-601-ingestion-manifest-resolve-part-deux' of...

    Compare with previous version

    Toggle commit list
  • Janet Goldstein merged

    merged

    • Please register or sign in to reply