WS-601: Fixed broken EVLA CAL test

• Correction: Manifests for EVLA CAL ingestion have no "calibrate" parameter.

HEADS UP: this correction required introducing the assumption that "ngas_ingest" is always true for both standard imaging and EVLA CAL.

If no more bugs come to light and no additional requirements are introduced, this completes ingestion manifest creation for EVLA calibrations and standard imaging.

apps/cli/executables/pexable/ingest_envoy/ingest_envoy/ingestion_manifest.py

@@ -85,21 +85,30 @@ class ManifestIF(ManifestComponentIF):
             params = ManifestParameters(
                 telescope=self.telescope,
                 reingest=False,
-                ngas_ingest=False,
+                ngas_ingest=True,
                 calibrate=False,
                 staging_source_dir=self.staging_source_dir,
                 additional_metadata=additional_metadata,
             )
-        else:
+            self.additional_metadata = additional_metadata
+
+        elif self.sp_type == ScienceProductType.IMAGE:
             params = ManifestParameters(
                 telescope=self.telescope,
                 reingest=False,
-                ngas_ingest=False,
+                ngas_ingest=True,
                 calibrate=False,
                 staging_source_dir=self.staging_source_dir,
             )
 
-        self.additional_metadata = additional_metadata
+        else:
+            params = ManifestParameters(
+                telescope=self.telescope,
+                reingest=False,
+                ngas_ingest=True,
+                staging_source_dir=self.staging_source_dir,
+            )
+
         return params
 
     @abc.abstractmethod
@@ -136,6 +145,8 @@ class ManifestIF(ManifestComponentIF):
 class IngestionManifestBuilder:
     """Builds ingestion manifest and associated files from files in ingestion_path"""
 
+    # TODO?: We are making assumptions about the values of "reingest", "ngas_ingest",
+    #  and "calibrate"; is this valid?
     def __init__(
         self,
         staging_source_dir: Path,