Skip to content
Snippets Groups Projects

WS-601: addresses bug in additional_metadata section of image manifest

Merged WS-601: addresses bug in additional_metadata section of image manifest
WS-601-fix-addl-metadata-section into main
All threads resolved!
Merged Janet Goldstein requested to merge WS-601-fix-addl-metadata-section into main
All threads resolved!

This MR addresses bug in additional_metadata section of manifest that has a class repr rather than a JSON-serializable value

  • tests dump all JSON strings; if dumps succeed, the JSON is good
  • removed contrived test case
  • added test case based on what an image ingestion staging dir is likely to contain

TODO next MR: implement additional tests for new image ingestion test case

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Janet Goldstein resolved all threads

    resolved all threads

  • Nathan Hertz approved this merge request

    approved this merge request

  • Nathan Hertz resolved all threads

    resolved all threads

  • Janet Goldstein added 4 commits

    added 4 commits

    • ce6917ce - 1 commit from branch main
    • 89e0caa3 - WS-601: addresses bug in additional_metadata section of manifest that has a...
    • a7e8901e - WS-601: remove cruft
    • ef83e3dd - Merge branch 'WS-601-fix-addl-metadata-section' of...

    Compare with previous version

    Toggle commit list
  • Janet Goldstein merged

    merged

    • Please register or sign in to reply