Skip to content
Snippets Groups Projects

SWS-7: Finish "download" workflow template

Merged SWS-7: Finish "download" workflow template
SWS-7-download-workflow-template into main
1 unresolved thread
Merged Nathan Hertz requested to merge SWS-7-download-workflow-template into main
1 unresolved thread

Make it so the download workflow actually works and does things!

Edited by Nathan Hertz

Merge request reports

Merge request pipeline #454 passed

Stage: build-dev
Stage: unit-test-dev

Merge request pipeline passed for c94b1da1

Merged by Nathan HertzNathan Hertz 4 years ago (Feb 5, 2021 11:27pm UTC)

Loading

Pipeline #455 passed

Stage: build-dev
Stage: unit-test-dev
Stage: push-dev

Pipeline passed for 3a6927da on main

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nathan Hertz resolved all threads

    resolved all threads

  • Nathan Hertz
    Nathan Hertz @nhertz ·
    Author
    • TODO: Make it so workflow arguments can be sent in via HTTP request and ensure they are carried through the entire system
    • TODO: Hook up download capability with correct hard-coded arguments to T H E B U T T O N
    Edited by Nathan Hertz
  • Nathan Hertz added 2 commits

    added 2 commits

    • c40976ee - removed the env.js set up and replaced it using angular's environment system.
    • fa36e2b4 - Preparation for getting the button hooked up to the download capability

    Compare with previous version

  • Nathan Hertz added 1 commit

    added 1 commit

    • 4334fa2d - Preparation for testing the button with the download capability

    Compare with previous version

  • Nathan Hertz added 6 commits

    added 6 commits

    • 4334fa2d...867b5ba8 - 4 commits from branch main
    • fad5a36a - Refactored CapabilityStep.from_str() to allow for multiple step args of
    • 9b766720 - Preparation for testing the button with the download capability

    Compare with previous version

  • Nathan Hertz marked this merge request as ready

    marked this merge request as ready

  • Nathan Hertz enabled an automatic merge when the pipeline for 9b766720 succeeds

    enabled an automatic merge when the pipeline for 9b766720 succeeds

  • Nathan Hertz aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • Nathan Hertz added 1 commit

    added 1 commit

    • c94b1da1 - Fixed tests to work with CapabilityStep parsing changes

    Compare with previous version

  • Nathan Hertz enabled an automatic merge when the pipeline for c94b1da1 succeeds

    enabled an automatic merge when the pipeline for c94b1da1 succeeds

  • Nathan Hertz merged

    merged

  • Charlotte Hausman
    Charlotte Hausman @chausman started a thread on the diff
    • shared/workspaces/workspaces/capability/helpers.py
    122 165 # DO NOT TAKE THIS OUT! Python will yell at you.
    123 166 parameters = json.dumps(parameters)
    124 167 workflow_args = json.loads(parameters)
    125 engine.submit_workflow_request(execution.id, workflow_name, workflow_args, files)
    168 engine.submit_workflow_request(workflow_name, workflow_args, files)
    Please register or sign in to reply