WS-797: Polishing QA process

Changes

Back-end

• Added new determine_state method to CapabilityRequest that will determine request state automatically, based on the state of its versions
• Capability execution state transitions now occur before the action is performed, so effectively the action is performed from the next state

UI

• "Submit" button now appears based on the state of the selected version rather than the state of the request
• The request's latest version is now selected by default in the dropdown
• Removed extraneous QA-pass button

Completes WS-798 and WS-801

apps/web/src/app/workspaces/components/capability-request/capability-request.component.html

@@ -6,10 +6,10 @@
     <div class="row">
       <div id="capability-definition-container" class="col-5">
         <span id="capability-label"
-        >Capability:
+          >Capability:
           <strong class="pl-1">{{
             this.capabilityRequest.capability_name.toUpperCase()
-            }}</strong></span
+          }}</strong></span
         >
         <app-capability-definition
           *ngIf="this.capability !== undefined"
@@ -29,7 +29,7 @@
             id="download-button"
             class="btn btn-warning"
             href="{{ this.capabilityExecution.delivery_url }}"
-          >Download</a
+            >Download</a
           >
         </div>
         <div *ngIf="this.capabilityRequest.current_execution !== null">
@@ -46,11 +46,11 @@
               href="/workflows/{{ this.capability.name }}/requests/{{
                 this.capabilityExecution.current_workflow_request_id
               }}/weblog"
-            >View Weblog</a
+              >View Weblog</a
             >
           </div>
         </div>
-        <br/>
+        <br />
         <div id="qa-container" class="col-5">
           <div
             class="d-flex justify-content-left py-3"
@@ -62,16 +62,6 @@
             "
           >
             <span id="qa-label">QA Processing: </span>
-            <button
-              id="set-qa-pass"
-              type="button"
-              class="btn btn-success"
-              (click)="passQa(this.capabilityExecution.current_workflow_request_id)"
-            >
-              <span class="fas fa-image"></span>
-              <span class="p1-2">Pass QA</span>
-            </button>
-
             <div class="btn-group">
               <div id="pass-button">
                 <button
@@ -108,11 +98,16 @@
           id="versions"
           class="pt-2"
           [capabilityRequest]="this.capabilityRequest"
-          (versionEvent) = setVersion($event)
+          [selected_version]="this.currentVersion"
+          (versionEvent)="setVersion($event)"
         ></app-versions>
-        <br/>
-        <span id="parameters-label" *ngIf="currentVersion !== undefined">Version {{currentVersion.version_number}} Parameters</span>
-        <span id="parameters-label" *ngIf="currentVersion === undefined">Version {{latestVersion.version_number}} Parameters</span>
+        <br />
+        <span id="parameters-label" *ngIf="currentVersion !== undefined"
+          >Version {{ currentVersion.version_number }} Parameters</span
+        >
+        <span id="parameters-label" *ngIf="currentVersion === undefined"
+          >Version {{ latestVersion.version_number }} Parameters</span
+        >
         <app-parameters
           id="parameters"
           class="pt-2"
@@ -125,9 +120,13 @@
           [currentVersion]="latestVersion"
           *ngIf="currentVersion === undefined"
         ></app-parameters>
-        <br/>
-        <span id="files-label" *ngIf="currentVersion !== undefined">Version {{currentVersion.version_number}} Files</span>
-        <span id="files-label" *ngIf="currentVersion === undefined">Version {{latestVersion.version_number}} Files</span>
+        <br />
+        <span id="files-label" *ngIf="currentVersion !== undefined"
+          >Version {{ currentVersion.version_number }} Files</span
+        >
+        <span id="files-label" *ngIf="currentVersion === undefined"
+          >Version {{ latestVersion.version_number }} Files</span
+        >
         <app-files
           id="files"
           class="pt-2"
@@ -140,22 +139,21 @@
           [capabilityVersion]="latestVersion"
           *ngIf="currentVersion === undefined"
         ></app-files>
-        <br/>
+        <br />
         <app-metadata
           id="metadata"
           class="pt-2"
           [capabilityVersion]="currentVersion"
-          *ngIf="
-            currentVersion !== undefined && currentVersion.workflow_metadata !== null
-          "
+          *ngIf="currentVersion !== undefined && currentVersion.workflow_metadata !== null"
         ></app-metadata>
-        <br/>
+        <br />
 
         <app-request-operations
           id="operations"
           class="pt-2"
           [capability]="this.capability"
           [capabilityRequest]="this.capabilityRequest"
+          [currentVersion]="currentVersion"
           (cartaLaunched)="alertMessage($event)"
         ></app-request-operations>
       </div>