WS-797: Polishing QA process (!657) · Merge requests · ssa / workspaces · GitLab

Snippets Groups Projects

Merged Nathan Hertz requested to merge WS-797-set-request-state-using-version-state into main 3 years ago

1 unresolved thread

Changes

Back-end

Added new determine_state method to CapabilityRequest that will determine request state automatically, based on the state of its versions
Capability execution state transitions now occur before the action is performed, so effectively the action is performed from the next state

UI

"Submit" button now appears based on the state of the selected version rather than the state of the request
The request's latest version is now selected by default in the dropdown
Removed extraneous QA-pass button

Completes WS-798 and WS-801

Edited 3 years ago by Nathan Hertz

Activity

Nathan Hertz added 11 commits 3 years ago
added 11 commits

506deb30...9ba132b8 - 3 commits from branch main

5c1bd3fc - Added new method `determine_state` to the `CapabilityRequest` class that

3dfb6d78 - Made it so latest version is the default selected version in the UI;

0547a024 - Removed extraneous QA-pass button

6c342cd4 - UI capability version fixes

2801c10d - Capability version state is now correctly set to Complete and Failed

df1152e2 - Test changed with renamed method

e65b2a10 - Request state is now set to Complete only if the current version for the

877ee7ff - Latest version now updates in real-time again; other versions do not

Compare with previous version
Toggle commit list
Nathan Hertz changed the description 3 years ago

changed the description
Charlotte Hausman approved this merge request 3 years ago

approved this merge request
Daniel Lyons @dlyons started a thread on the diff 3 years ago

shared/workspaces/workspaces/capability/schema.py

     def update_state(self, state: CapabilityRequestState):
         self.state = state.name
     def determine_state(self):

Daniel Lyons approved this merge request 3 years ago

approved this merge request

Janet Goldstein @jgoldste started a thread on an old version of the diff 3 years ago

Resolved 3 years ago by Nathan Hertz

Janet Goldstein approved this merge request 3 years ago

approved this merge request

Nathan Hertz added 9 commits 3 years ago

added 9 commits

0dc165ca - Added new method `determine_state` to the `CapabilityRequest` class that
5cde5b2c - Made it so latest version is the default selected version in the UI;
738aad52 - Removed extraneous QA-pass button
d59fcd44 - UI capability version fixes
4d7fc754 - Capability version state is now correctly set to Complete and Failed
bc4d3648 - Test changed with renamed method
7e896241 - Request state is now set to Complete only if the current version for the
a085ba9b - Latest version now updates in real-time again; other versions do not
cc3cb0b7 - Fixing tests; the method in the test was not supposed to be renamed

Compare with previous version

Toggle commit list

Nathan Hertz added 1 commit 3 years ago

added 1 commit

5019fa41 - Move pylint disables

Compare with previous version

Nathan Hertz merged 3 years ago

merged

Please register or sign in to reply