WS-858: fix bugs in `create_follow_on_capability_request`, hopefully for the last time

• create_follow_on_capability_request "should" be correct now

TODO next MR: get unit test to work and not break other tests

apps/web/src/app/workspaces/components/capability-request/components/create-new-version-form/create-new-version-form.component.ts

@@ -17,7 +17,7 @@
  * along with Workspaces.  If not, see <https://www.gnu.org/licenses/>.
  */
 import { Component, Input, OnInit } from "@angular/core";
-import { ModalDismissReasons, NgbModal } from "@ng-bootstrap/ng-bootstrap";
+import { NgbModal } from "@ng-bootstrap/ng-bootstrap";
 import { CapabilityRequest } from "../../../../model/capability-request";
 import { CapabilityRequestService } from "../../../../services/capability-request.service";
 import { CapabilityVersion } from "../../../../model/capability-version";
@@ -95,17 +95,18 @@ export class CreateNewVersionFormComponent implements OnInit {
     const idString = this.selectedVersion.capability_request_id.toString();
     const createNewVersionObservable = {
       next: (response) => {
-        if (this.inputFileList !== undefined) {
-          this.capabilityRequestService.addFilesToVersion(
-            idString,
-            this.inputFileList,
-          );
+        if (this.inputFileList) {
+          this.capabilityRequestService.addFilesToVersion(idString, this.inputFileList);
         }
       },
       error: (error) => alert("Error when creating new version:" + error),
     };
     this.capabilityRequestService
-      .createNewVersion(this.selectedVersion.capability_request_id, this.parametersString, this.inputFileList)
+      .createNewVersion(
+        this.selectedVersion.capability_request_id,
+        this.parametersString,
+        this.inputFileList,
+      )
       .subscribe(createNewVersionObservable);
   }