Skip to content
Snippets Groups Projects
Commit 11f39e84 authored by Charlotte Hausman's avatar Charlotte Hausman
Browse files

add DOOM comment

parent 07df07d1
No related branches found
No related tags found
2 merge requests!1390Catch up with Main,!1344make sure CARTA opens only after setup finishes
Pipeline #9830 passed
...@@ -188,7 +188,11 @@ class CartaLauncher: ...@@ -188,7 +188,11 @@ class CartaLauncher:
try: try:
# finish setup for CARTA and ensure completion before launch # finish setup for CARTA and ensure completion before launch
CartaWrapperLauncher.deploy_wrapper_html(file_browser_path, carta_url, session_timeout_date) CartaWrapperLauncher.deploy_wrapper_html(file_browser_path, carta_url, session_timeout_date)
time.sleep(3) # BIG NASTY COMMENT OF DOOM!!!!!
# DO NOT REMOVE!!
# This is required to ensure that proxy url setup is complete *before* CARTA launches.
# Without this, users are presented with a 404 page on launch as of CARTA3
time.sleep(2)
# start CARTA # start CARTA
CARTA_PROCESS = subprocess.Popen( CARTA_PROCESS = subprocess.Popen(
...@@ -202,8 +206,6 @@ class CartaLauncher: ...@@ -202,8 +206,6 @@ class CartaLauncher:
self.teardown() self.teardown()
sys.exit(f"ERROR: Failed to launch CARTA: {err}") sys.exit(f"ERROR: Failed to launch CARTA: {err}")
else: else:
# CartaWrapperLauncher.deploy_wrapper_html(file_browser_path, carta_url, session_timeout_date)
# CARTA is running and accessible, so send CARTA URL to AAT system or notify user # CARTA is running and accessible, so send CARTA URL to AAT system or notify user
self.notify_ready(wrapper_url) self.notify_ready(wrapper_url)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment