Skip to content
Snippets Groups Projects

Fix the core sampler access to project code linking table.

Merged Brittany Faciane requested to merge fixProjectCodeInSampler into 2.8.2.3-DEVELOPMENT
All threads resolved!

Somewhere, somehow, the link to the science_products_projects table got broken. This fixes the core sampler for the last time (probably).

Merge request reports

Merge request pipeline #14505 passed

Merge request pipeline passed for a108686b

Approved by

Merged by Brittany FacianeBrittany Faciane 1 year ago (Mar 1, 2024 10:03pm UTC)

Merge details

  • Changes merged into 2.8.2.3-DEVELOPMENT with d845934c.
  • Deleted the source branch.

Pipeline #14512 passed

Pipeline passed for d845934c on 2.8.2.3-DEVELOPMENT

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Daniel Nemergut resolved all threads

    resolved all threads

  • added 1 commit

    • 912e6a60 - Adding an exception for wrong number of project code values.

    Compare with previous version

  • Charlotte Hausman approved this merge request

    approved this merge request

  • Sam Kagan approved this merge request

    approved this merge request

  • Daniel Nemergut approved this merge request

    approved this merge request

  • Sam Kagan unapproved this merge request

    unapproved this merge request

    • Resolved by Sam Kagan

      In my testing, I found that, when trying to image-correct a product group with 2 science products, I get back 2 project codes. I updated the error message on line 363 to give some debugging info, and in this case it says:

      Expected 1 project code for SPLs in the same product group (['uid://evla/fits_image/0569c840-d9ea-48da-979c-118b1821707e', 'uid://evla/fits_image/b023c3e8-1ded-43f1-95a2-96bc21c976ef']), found instead 2 project codes: [RealDictRow([('project_code', '20A-154')]), RealDictRow([('project_code', '20A-154')])]
      Edited by Sam Kagan
  • added 1 commit

    • a108686b - Adding distinct clause to project code query.

    Compare with previous version

  • Sam Kagan approved this merge request

    approved this merge request

  • Sam Kagan resolved all threads

    resolved all threads

  • Brittany Faciane mentioned in commit d845934c

    mentioned in commit d845934c

  • Please register or sign in to reply
    Loading