Skip to content
Snippets Groups Projects

WS-649: send CARTA URL to workspaces system

Merged Janet Goldstein requested to merge WS-649-send-carta-url-to-ws into main
All threads resolved!

The mock messaging system being inoperable, these mods can be "tested" only by running CARTA Envoy on dev, which I will do following merge.

Merge request reports

Merge request pipeline passed for a7809809

Test coverage 65.00% (0.00%) from 1 job
Approval is optional

Merged by Janet GoldsteinJanet Goldstein 3 years ago (Sep 15, 2021 4:01pm UTC)

Merge details

  • Changes merged into main with 71737362.
  • Deleted the source branch.

Pipeline #2890 passed

Pipeline passed for 71737362 on main

Test coverage 65.00% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 82c9f939 - WS-649: message name still wasn't right

    Compare with previous version

  • Charlotte Hausman approved this merge request

    approved this merge request

  • added 1 commit

    • d3d3f3a5 - WS-649: skip test that uses broken mock

    Compare with previous version

  • Daniel Lyons
  • Daniel Lyons
    • Resolved by Janet Goldstein

      It doesn't seem like this MR's changes do anything because the message you're sending in send_carta_url_to_ws doesn't have a handler anywhere. So all this seems to culminate in a no-op unless a handler is created for that AMQP message that sets the field in the database.

  • Janet Goldstein added 5 commits

    added 5 commits

    • 461ddc2f - WS-649: infrastructure for sending CARTA event info to Workspaces system
    • 3e666673 - WS-649: message name still wasn't right
    • f456603d - WS-649: skip test that uses broken mock
    • dc71c2e4 - WS-649: addresses issues found with MR 502
    • a7809809 - Merge branch 'WS-649-send-carta-url-to-ws' of...

    Compare with previous version

  • Daniel Lyons approved this merge request

    approved this merge request

  • Charlotte Hausman unapproved this merge request

    unapproved this merge request

  • Charlotte Hausman approved this merge request

    approved this merge request

  • Janet Goldstein resolved all threads

    resolved all threads

  • Nathan Hertz approved this merge request

    approved this merge request

  • Please register or sign in to reply
    Loading