Skip to content
Snippets Groups Projects

WS-290: Fix QA

Merged Nathan Hertz requested to merge WS-290-fix-qa into main
1 unresolved thread
  • Fixed QA messages getting sent with the wrong messenger
  • Change [SendMessage: qa_ready] action to new [AnnounceQa] action that will correctly announce that QA is ready using REST
  • Verified that QaPass action fails non-current versions

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
189 188 self._fail_other_versions(request)
190 189
191 190
191 class AnnounceQa(Action):
192 """
193 Action that makes a REST call to the announce_qa endpoint in the workflow service, which announces that an execution
194 is ready for QA
195 """
196
197 __mapper_args__ = {"polymorphic_identity": "AnnounceQa"}
198
199 def __call__(self, execution: CapabilityExecutionIF, *args):
200 workflow_request_id = execution.current_workflow_request_id
201 msg_type = "qa_ready"
202 workflow_service_url = CapoConfig().settings("edu.nrao.workspaces.WorkflowSettings").serviceUrl
203 url = f"{workflow_service_url}/workflows/requests/{workflow_request_id}/qa/{msg_type}"
Please register or sign in to reply
Loading