Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
workspaces
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
ssa
workspaces
Merge requests
!649
WS-290: Fix QA
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
WS-290: Fix QA
WS-290-fix-qa
into
main
Overview
1
Commits
3
Pipelines
2
Changes
1
Merged
Nathan Hertz
requested to merge
WS-290-fix-qa
into
main
3 years ago
Overview
1
Commits
3
Pipelines
2
Changes
1
Expand
Fixed QA messages getting sent with the wrong messenger
Change [SendMessage: qa_ready] action to new [AnnounceQa] action that will correctly announce that QA is ready using REST
Verified that QaPass action fails non-current versions
0
0
Merge request reports
Viewing commit
2cc3ef2d
Prev
Next
Show latest version
1 file
+
51
−
0
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
2cc3ef2d
Change [SendMessage: qa_ready] action to new [AnnounceQa] action that
· 2cc3ef2d
Nathan Hertz
authored
3 years ago
will correctly announce that QA is ready using REST
schema/versions/ced8e001d262_change_sendmessage_qa_ready_action_to_.py
0 → 100644
+
51
−
0
Options
"""
change SendMessage qa_ready action to AnnounceQa action
Revision ID: ced8e001d262
Revises: acfdeb6777cb
Create Date: 2021-11-10 10:16:09.070171
"""
from
alembic
import
op
# revision identifiers, used by Alembic.
revision
=
"
ced8e001d262
"
down_revision
=
"
acfdeb6777cb
"
branch_labels
=
None
depends_on
=
None
def
upgrade
():
"""
Modify action that gets triggered on QA workflow complete;
Change it to perform the AnnounceQa action instead of attempting to SendMessage with arguments qa_ready
"""
op
.
execute
(
"""
UPDATE capability_state_actions SET action_type =
'
AnnounceQa
'
, arguments = null
WHERE action_type =
'
SendMessage
'
AND arguments =
'
qa_ready
'
AND transition_id = (
SELECT transition_id FROM capability_state_transitions
WHERE pattern =
'
type == workflow-complete
'
AND capability_name =
'
std_calibration
'
)
"""
)
def
downgrade
():
"""
Undo above change
"""
op
.
execute
(
"""
UPDATE capability_state_actions SET action_type =
'
SendMessage
'
, arguments =
'
qa_ready
'
WHERE action_type =
'
AnnounceQa
'
AND arguments IS null
AND transition_id = (
SELECT transition_id FROM capability_state_transitions
WHERE pattern =
'
type == workflow-complete
'
AND capability_name =
'
std_calibration
'
)
"""
)
Loading