Skip to content
Snippets Groups Projects

WS-797: Polishing QA process

Merged Nathan Hertz requested to merge WS-797-set-request-state-using-version-state into main
1 unresolved thread
2 files
+ 43
12
Compare changes
  • Side-by-side
  • Inline
Files
2
@@ -70,15 +70,16 @@ class CapabilityService(CapabilityServiceIF):
def complete_request(self, **message: Dict):
logger.info(f"RECEIVED EXECUTION-COMPLETE: {message}")
# Set request state to Complete
execution = message["subject"]
# Update request state
capability_request = self.capability_info.lookup_capability_request(execution["capability_request_id"])
capability_request.determine_state()
self.capability_info.save_entity(capability_request)
# Set version state to Complete
# Set version state to Complete if the execution is indeed complete; else, leave it alone
version = self.capability_info.lookup_version(capability_request.id, execution["version_number"])
version.state = CapabilityVersionState.Complete.name
version.state = CapabilityVersionState.Complete.name if execution["state_name"] == "Complete" else version.state
self.capability_info.save_entity(version)
capability_complete_msg = CapabilityMessageArchitect(request=capability_request).compose_message(
@@ -92,8 +93,7 @@ class CapabilityService(CapabilityServiceIF):
execution = message["subject"]
# Set request state to Failed
# TODO(nhertz): Dynamically calculate request state based on the states of its versions
# Update request state
capability_request = self.capability_info.lookup_capability_request(execution["capability_request_id"])
capability_request.determine_state()
self.capability_info.save_entity(capability_request)
Loading