Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
workspaces
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
ssa
workspaces
Merge requests
!657
WS-797: Polishing QA process
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
WS-797: Polishing QA process
WS-797-set-request-state-using-version-state
into
main
Overview
3
Commits
10
Pipelines
4
Changes
1
1 unresolved thread
Hide all comments
Merged
Nathan Hertz
requested to merge
WS-797-set-request-state-using-version-state
into
main
3 years ago
Overview
3
Commits
10
Pipelines
4
Changes
1
1 unresolved thread
Hide all comments
Expand
Changes
Back-end
Added new
determine_state
method to
CapabilityRequest
that will determine request state automatically, based on the state of its versions
Capability execution state transitions now occur before the action is performed, so effectively the action is performed from the next state
UI
"Submit" button now appears based on the state of the selected version rather than the state of the request
The request's latest version is now selected by default in the dropdown
Removed extraneous QA-pass button
Completes
WS-798
and
WS-801
Edited
3 years ago
by
Nathan Hertz
0
0
Merge request reports
Viewing commit
cc3cb0b7
Prev
Next
Show latest version
1 file
+
1
−
1
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
cc3cb0b7
Fixing tests; the method in the test was not supposed to be renamed
· cc3cb0b7
Nathan Hertz
authored
3 years ago
shared/workspaces/test/test_states.py
+
1
−
1
Options
@@ -100,7 +100,7 @@ class MealyMachine:
self
.
signal
({
"
event_type
"
:
"
start
"
})
def
signal
(
self
,
message
:
Dict
):
self
.
state
=
self
.
state
.
perform_action
(
message
)
self
.
state
=
self
.
state
.
signal
(
message
)
def
complete
(
self
):
return
self
.
state
.
accepting_state
()
Loading