This is two lines of thought combined into one merge:

1. AMQP clients should either receive messages or send messages
2. Capability queues are based on a database-backed queue manager rather than keeping state in-memory

Most of the work relating to the first idea comes in refactoring the Router to not be a message sender. Many places in the code now either instantiate a MessageSender instead, or use both a Router and a MessageSender if they truly needed both functionalities. The previous implementation appears to have caused messages to arrive out of order because facilities like `wf_monitor` that only send messages were also trying to receive messages, and either not handling them at all or putting them into a buffer of some kind to be dropped on the floor when the process ended.

The work relating to the second idea changes the way that steps are processed in the capability service and eliminates the capability engine concept. Now when PrepareAndRunWorkflow steps are reached, the capability is simply moved into the Waiting state and the queue manager is signaled. Whenever the queue manager is awakened, it checks to see if any queues have slots available and requests waiting. If they do, the number of available slots are used to get requests and start executing them. When an execution exits the cluster, the queue manager is signaled again, so the process continues until all the jobs are processed. As a stability benefit, we check this on startup as well.

Nathan Hertz authored 3 years ago and Nathan Hertz committed 3 years ago

request

Daniel Lyons authored 3 years ago and Daniel Lyons committed 3 years ago

Refactor the WorkflowService into two pieces:
  - a MessagingHandler, which connects to AMQP and does the handling of those events, and
  - a per-request WorkflowService that handles web requests as they come in